Fix documentation page sidebar bug #3327
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3327 +/- ##
=======================================
Coverage 60.79% 60.79%
=======================================
Files 606 606
Lines 43794 43794
Branches 48 48
=======================================
Hits 26623 26623
Misses 17159 17159
Partials 12 12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
johannaengland
added
the
nonews
johannaengland
approved these changes
Mar 17, 2025
|
@jorund1 if you rebase this on the latest master, the tests should become green again :) |
jorund1
force-pushed
the
fix-documentation-page-sidebar-bug
branch
from
10a6ed3 to
2f61b54
Compare
lunkwill42
requested changes
Mar 25, 2025
doc/reference/web_authentication.rst
Outdated
|
|
||
| ../howto/mod_auth_openidc_feide | ||
| :ref:`openidc_feide_howto` |
There was a problem hiding this comment.
I don't really see the point of switching to a named cross-reference when the reference is to a whole document and not a specific section of a document. The old link worked just fine, but the toctree seemed malplaced...
(place link in list to mimic original look as well)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A documentation page is included in two TOCs, which seems to cause some anomalies.
Currently, this howto-page appears to be listed under 'Reference material' instead of 'Howtos' in the sidebar.
This PR fixes this anomaly by making sure it is only listed in the 'Howtos' TOC.